From 208f02d61277ed0a63cc19fdb123e9592d37ce86 Mon Sep 17 00:00:00 2001 From: krisf Date: Fri, 9 Oct 2026 17:53:18 -0400 Subject: [PATCH] audit: math-fix seventeenth-pass re-verification (all gates fresh, OFFLAN-OK 21:52Z, deploy + 34/34 byte sweep, passes3 + DOM rows byte-identical to passes 14/15/16) --- MATH-FIX-REPORT.md | 24 ++++++++++++++++++++++++ audit/bilingual-geo-check.json | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/MATH-FIX-REPORT.md b/MATH-FIX-REPORT.md index a0b9e69..467530b 100644 --- a/MATH-FIX-REPORT.md +++ b/MATH-FIX-REPORT.md @@ -463,3 +463,27 @@ Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main`; all gates fresh this pass. Final: **MATH_FIX_DONE**. Addendum (post-push, same pass): audit commit `9bd07adeba2f733a…` pushed `3c76b7f..9bd07ad` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, so the sweep carries over by construction). +--- + +## Re-verification (seventeenth DSH pass, 2026-10-09 21:52–21:56 UTC, post-completion) + +Queue gate: `git status --porcelain` empty at start, HEAD `97123a1` == `origin/main` (post-fetch), no job in flight → proceed (not `DSH_QUEUE_BUSY`). Fix 1–4 re-audited by direct read of the working tree (== HEAD, zero tracked diff): GIS 65+ floor — `a >= 65 ? gis(…) : 0` at the three `solve()` sites (engine.js:249/260/265) + Service Canada source-fact comment (:89) + merge per-partner ≥65 gates (:376/:379–380) + `if (yr < 65) gisSum = 0;` (:382); clawback only with OAS — `oasGross > 0 ? Math.min(clawback(…), oasGross) : 0` at :248/:259 + s.3(1) ETA comment :80–83 + splitting-solver parity :366–367; mixed rows — `row.mixed` :390 + depletion guard `!row.mixed` :395 + renderer `†`/legend app.js:807–819 + legend element index.html:95 + `t.mixedNote` EN/FR i18n.js:251/512; FIRE — `fillDefaults` clamp `retireAge < age+1` engine.js:188, quiz slider `min: 40` app.js:211, `#wi-ret min="40"` index.html:86, FIRE hint EN/FR i18n.js:96/357. All acceptance checks re-executed fresh in this pass: + +| Check | Fresh output (this pass) | +|---|---| +| `tests/engine.test.js` | `RESULT: 61 pass, 0 fail` (incl. §14 T1 repro GIS $0 @56 / clawback $0 @55 / net OAS ≥ 0 everywhere, §15 clawback 0 pre-OAS & capped at OAS gross @67, §16 couple invariants + depletion-guard-never-fires-on-mixed, §17 fillDefaults 52→53 & 30→40, FIRE first draw 40, GIS/clawback 0 rows 40–64, stale 52/40 → first draw 53) | +| `tests/i18n.test.js` | `I18N-OK all i18n checks passed (50)` (incl. `t.mixedNote` EN+FR parity, `q.retire.hint` FIRE EN+FR) | +| `tests/ui.smoke.js` | `SMOKE-OK all ui smoke checks passed (146)` (incl. † mixed-row fixture ×3 + bilingual legend EN+FR, control-single no †, `wi-ret min 40`, legend element present) | +| `tests/ps-pension.test.js` / `ps-auto-service.test.js` | `70 pass, 0 fail` / `21 pass, 0 fail` (unchanged files) | +| `passes3.js` rerun (live engine) | exit 0, `conservation: OK` ×3 → `audit/math-fix/passes3-pass17.log` (copied to `passes3-thispass.log`; md5 `01075d0e…` — **byte-identical to passes 14/15/16** ⇒ engine output deterministic across four passes). PASS 1 (screenshot repro): programmatic scan of all 43 rows — **0** rows <65 with GIS>0, **0** with OASnet≠0, **0** negative-OASnet rows anywhere (plan evidence −$3,501 @55, $12,916 @56, phantom $13,667/yr to 94 all gone); first GIS row **65** (GIS $12,567, OASnet $9,150); depletion 56 honest (nest egg $170,465 vs $93k spend, finalBal $0); **0** growing-Total-with-Withdraw consecutive rows; PASS 2 depletion 82, conservation OK; PASS 3 FIRE: first draw @**40** (Withdraw $62,837, CPP/OAS/GIS $0), max total $493,710 @39 = hand-math 350000×1.035¹⁰ ✓, GIS $13,667 first at 65, **0** pre-65 GIS rows, depletion 48 → unfunded gap exposed (Unfunded $57,613 @60 = $60,000 − CPP $2,387, to 94) | +| `scripts/deploy.sh` | `DEPLOY-OK` (fresh this pass) | +| Origin byte-check | 3-way sweep `.tmp/mathfix17/sweep17.sh` (pass-15 script, file lists regenerated from git — byte-identical to the prior lists; ssh `-n`, one remote md5 pass): local `site/` == `git cat-file origin/main:` == webroot `/mnt/better/appdata/retireapp` — tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch** → `SWEEP-OK`; `HEAD` == `origin/main` == `97123a1` | +| Live recapture (`mathfix_capture.py after17` + canonical `after`, retire.krisforbes.ca) | couple 52/52 ret 55 spend 93k CPP 60, all 40 DOM rows 55–94 parsed with the K-aware 11-column parser (`.tmp/mathfix17/rowsweep.py`): **0** negative-OAS cells, **0** GIS>0 rows <65, **0** OAS≠0 rows <65, **0** growing-Total-with-Withdraw rows on consecutive ages → `ROWSWEEP-OK` on all three row JSONs; first draw **55**, first GIS row **65**; rows 58–64 Total $0 / OAS $0 / GIS $0 (Withdraw $49K @58 then $0, Unfunded $47K→$93K→$79K from CPP@60 — honest post-depletion drain, vs the screenshot's impossible 126→141K @3.5%); `wiRetMin: "40"`. FIRE 30/BC/ret 40 (`after-fire-rows.json`, 57 rows 30–94): first Withdraw>0 row age **40**, first GIS row 65, **0** pre-65 GIS / neg-OAS / growing-consecutive violations. Mobile 390: retire slider `min=40 max=72 value=40`, `sliderRight 367 ≤ vw 390` (no clip), value chip [25, 145], FIRE hint present EN, `svAfter40: "40 years"` | +| Live mixed-window probe (`after17-mixed-*`, re-run of the pass-14/15/16 probe) | couple me 52 / pt 50, `retireAge: 51` → `fillDefaults` clamps self to 53; partner inherits the shared clamped 53 → both draw from 53 (DOM row 53 Withdraw $93K, Total $237K; row 50 accum, Total $155K / Withdraw $0) → **0 † rows**, `noteShown: false`, K-aware re-parse: **0** GIS>0 rows <65, **0** OAS≠0 rows <65, **0** negative-OAS cells, **0** growing-Total-with-Withdraw → reconfirms Deviation 2 (age-axis merge + shared clamped `retireAge` ⇒ mixed draw windows are unreachable in the live couple path); the `†` suffix + bilingual legend rendering is proven by the `ui.smoke.js` `project()` fixture (3 flagged rows, EN+FR) and the engine §16 invariants | +| Off-LAN (Midhurst `trouble@100.96.20.61`) | `OFFLAN-OK`, `"all_ok": true`, `"http_code": "200"`, `checked_at 2026-10-09T21:52:45Z` → `audit/bilingual-geo-check.json` | + +Determinism: `after17-couple-rows.json` **byte-identical** to the canonical `after-couple-rows.json` re-captured in the same session (md5 `129e2a45…` — same as passes 14/15/16); `after17-mixed-rows.json` byte-identical to `after15/16-mixed-rows.json` (md5 `96665bbf…`). Frame set as characterized in passes 14/15/16: the `after17` couple run landed on the known chart-animation-phase frame `eec99021c08c…` 63,753 B (pass-11/13/14/15/16 variant) with DOM row JSON byte-identical to canonical, and the canonical `after` run **landed on the canonical frame on the first attempt** — 1280×900 50,314 B md5 `cbac51ed5089…`, byte-identical to the canonical renders of passes 1/8/9/10/11/12/13/14/15/16. Fresh PNGs IHDR-validated: `after17-couple-table.png` (1280×900 63,753 B, anim-phase frame) / `after17-mixed-table.png` (1280×900 64,537 B, md5 `222c81a1…` — byte-identical to `after14-mixed-table.png`) / `after-couple-table.png` (1280×900 50,314 B canonical) / `after-fire-table.png` (1280×900 67,310 B, md5 `685fd711…` byte-identical to prior passes), `after-fire-step-390.png` 1170×2532 @3× 167,045 B (md5 `761e8055…`, stable). + +Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner/.pwtmp` (harness TMPDIR read-only; no site impact); ssh byte-check uses `-n`; this pass rebuilt the sweep + K-aware rowsweep + mixed probe under `.tmp/mathfix17/` (gitignored) — sweep file lists regenerated with `git ls-files` (21 tracked + 13 ignored, byte-identical to the pass-15/16 lists); rowsweep copied from pass 16 with only the detail-block filename retargeted to `after17-couple-rows.json`; all three ran unmodified otherwise. `audit/math-fix/` is gitignored by design — artifacts are local evidence, referenced by path. + +No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main`; all gates fresh this pass. Final: **MATH_FIX_DONE**. diff --git a/audit/bilingual-geo-check.json b/audit/bilingual-geo-check.json index d3a7e63..3d62aef 100644 --- a/audit/bilingual-geo-check.json +++ b/audit/bilingual-geo-check.json @@ -5,7 +5,7 @@ "has_i18n_script": true, "i18n_js_fr_strings": true, "i18n_js_size": 39689, - "checked_at": "2026-10-09T21:49:26Z", + "checked_at": "2026-10-09T21:52:45Z", "vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)", "all_ok": true } \ No newline at end of file