audit: math-fix ninth-pass re-verification (all gates fresh, OFFLAN-OK 21:21Z, deploy + 21/21 byte sweep)

This commit is contained in:
krisf committed 2026-10-09 17:22:26 -04:00
1 parent 2e4e0963a4
commit 5ec2bf6ce5
2 files changed
+24 -1

No files matched your search

+23
View File
@@ -265,3 +265,26 @@ Queue gate: `git status --porcelain` empty at start (no untracked, no tracked di
Harness notes: Playwright run with `TMPDIR=/home/ubuntu/projects/retire-planner/.pwtmp` (harness TMPDIR read-only; no site impact); this model has no image input, so PNGs validated by IHDR dimensions + file size + the DOM row scrapes (content evidence) rather than visual inspection; ssh byte-check uses `-n` (plain ssh eats loop stdin).
No code change required — plan executed end-to-end; commit `0839826` at `origin/main`. Final: **MATH_FIX_DONE**.
---
## Re-verification (ninth DSH pass, 2026-10-09 21:22 UTC, post-completion)
Queue gate: `git status --porcelain` empty at start, HEAD `f2eca41` == `origin/main`, no job in flight → proceed (not `DSH_QUEUE_BUSY`). Fix 1–4 re-audited in HEAD by direct file read: GIS `a >= 65 ? gis(…) : 0` at the three `solve()` sites (engine.js:249/260/265, Service Canada source comment :88–91) + merge per-partner ≥65 gates (:376–380) + `if (yr < 65) gisSum = 0;` (:382); clawback `oasGross > 0 ? Math.min(clawback(…), oasGross) : 0` at :248/:259 + split-solver parity :366–367; `row.mixed` :390 + depletion guard `!row.mixed` :395; `fillDefaults` clamp `retireAge < age+1` :188; quiz slider `min: 40` app.js:211 + `#wi-ret min="40"` index.html:86; `t.mixedNote` EN/FR i18n.js:251/512 + `#yr-mixed-note` index.html:95; FIRE hint EN/FR i18n.js:96/357. All acceptance checks re-executed fresh in this pass:
| Check | Fresh output (this pass) |
|---|---|
| `tests/engine.test.js` | `RESULT: 61 pass, 0 fail` (T1 clawback $0 @55 / GIS $0 @56 / no GIS<65 anywhere, T2 100k draw @55 cw 0 + 150k draw @67 cw > 0 and capped at OAS, couple GIS/claw zero <65 + net OAS ≥ 0 + no growing-Total draw rows + GIS household rate @70, age-offset window rows 50–54, depletion guard intact, fillDefaults 52→53 & 30→40, FIRE first draw 40 + rows 40–64 GIS/clawback 0) |
| `tests/i18n.test.js` | `I18N-OK all i18n checks passed (50)` (incl. `t.mixedNote` EN+FR, `q.retire.hint` FIRE EN+FR) |
| `tests/ui.smoke.js` | `SMOKE-OK all ui smoke checks passed (146)` (incl. † mixed-row fixture + bilingual legend, control-single clean, `wi-ret min 40`, legend element present) |
| `tests/ps-pension.test.js` / `ps-auto-service.test.js` | `70 pass, 0 fail` / `21 pass, 0 fail` (unchanged files) |
| `passes3.js` rerun (live engine) | exit 0, `conservation: OK` ×3 → `audit/math-fix/passes3-pass9.log`. PASS 1 (screenshot repro): rows 55–64 **OASnet $0 / GIS $0** (plan evidence: −$3,501 @55, $12,916 @56 + phantom $13,667/yr to 94), first GIS row 65 ($12,567, OASnet $9,150), depletion 56 honest ($170,465 nest egg vs $93k spend); PASS 2 depletion 82, GIS 65+ only; PASS 3 FIRE: first draw 40 (Withdraw $62,837, CPP/OAS/GIS $0), max total $493,710 @39 = hand-math 350000×1.035¹⁰ ✓ |
| `scripts/deploy.sh` | `DEPLOY-OK` (fresh this pass) |
| Origin byte-check | md5 curl-vs-local **4/4 BYTE-OK** (engine/engine.js, app.js, i18n.js, index.html); full 3-way sweep local == `git cat-file origin/main:` == webroot: **21/21 match** (13 `site/vision/*.jpeg` intentionally gitignored) |
| Live recapture (`mathfix_capture.py after`, retire.krisforbes.ca) | couple 52/52 ret 55 spend 93k CPP 60, DOM rows scraped: **0** negative-OAS cells, **0** GIS>0 rows <65, first GIS row 65; rows 58–64 Total $0 / OAS $0 / GIS $0, Withdraw $49K @58 then $0, Unfunded $47K–$93K — **0 growing-Total-with-Withdraw rows**; `wiRetMin: "40"`; `noteShown: false` (correct — symmetric couple has no mixed rows, Deviation 2; †/legend proven by smoke fixture + engine §16). FIRE 30/BC/ret 40: first Withdraw>0 row age **40**, **0** pre-65 GIS/neg-OAS violations. Mobile 390: slider `min=40 value=40`, `sliderRight 367 ≤ vw 390` (no clip), value chip [25, 145], FIRE hint present, `svAfter40: "40 years"`. Fresh PNGs 21:21Z: `after-couple-table.png` 1280×900, `after-fire-table.png` 1280×900, `after-fire-step-390.png` 1170×2532 (IHDR-validated) |
| Live mixed-window probe (re-run) | couple me 52 / pt 50, `retireAge: 51` → `fillDefaults` clamps to 53; live DOM: rows 50 (partner accum) then both-partner draw from 53, **0 † rows**, `noteShown: false`, **0** GIS rows <65 — reconfirms Deviation 2 (age-axis merge + shared clamped `retireAge` ⇒ mixed draw windows unreachable live) |
| Off-LAN (Midhurst `trouble@100.96.20.61`) | `OFFLAN-OK`, `"all_ok": true`, `"http_code": "200"`, `checked_at 2026-10-09T21:21:32Z` → `audit/bilingual-geo-check.json` |
Harness notes: Playwright run with `TMPDIR=/home/ubuntu/projects/retire-planner/.pwtmp` (harness scratch read-only; no site impact); PNGs validated by IHDR dimensions + row-scrape content evidence.
No code change required — plan executed end-to-end; commit `0839826` at `origin/main`. Final: **MATH_FIX_DONE**.