From 83a4489e44258e511175f5dcd503b2d887411b70 Mon Sep 17 00:00:00 2001 From: krisf Date: Fri, 9 Oct 2026 18:14:11 -0400 Subject: [PATCH] audit: math-fix twenty-third-pass re-verification (all gates fresh, OFFLAN-OK 22:12Z, deploy + 34/34 byte sweep, passes3 + DOM rows byte-identical to passes 14-22, couple frame roles match pass 22) --- MATH-FIX-REPORT.md | 25 +++++++++++++++++++++++++ audit/bilingual-geo-check.json | 2 +- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/MATH-FIX-REPORT.md b/MATH-FIX-REPORT.md index ac481ae..b39d6da 100644 --- a/MATH-FIX-REPORT.md +++ b/MATH-FIX-REPORT.md @@ -623,3 +623,28 @@ Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main` (ancestor of HEAD, confirmed via `git merge-base --is-ancestor`); all gates fresh this pass. Final: **MATH_FIX_DONE**. Addendum (post-push, same pass): audit commit `d2f6e2071d8fd9996e49d8c2676a1f3976e9e0a1` pushed `aaa8ec5..d2f6e20` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, so the sweep carries over by construction). + +--- + +## Re-verification (twenty-third DSH pass, 2026-10-09 22:11–22:16 UTC, post-completion) + +Queue gate: `git status --porcelain` empty at start (HEAD `9838113` == `origin/main`) → proceed (not `DSH_QUEUE_BUSY`). Fix 1–4 re-audited by direct read of the working tree (== HEAD, zero tracked diff): GIS 65+ floor — `a >= 65 ? gis(…) : 0` at the three `solve()` sites (`site/engine/engine.js:249/260/265`) + Service Canada source-fact comment (:88–91) + merge per-partner ≥65 gates (:376/:379–380) + `if (yr < 65) gisSum = 0;` (:382); clawback only with OAS — `oasGross > 0 ? Math.min(clawback(…), oasGross) : 0` at :248/:259 + s.3(1) ETA comment :78–83 + splitting-solver parity :366–367; mixed rows — `row.mixed` :390 + depletion guard `!row.mixed` :395 + renderer `†`/legend `app.js:807–819` (:812 `†`, :818–819 legend) + legend element `index.html:95` + `t.mixedNote` EN/FR `i18n.js:251/512`; FIRE — `fillDefaults` clamp `retireAge < age + 1` engine.js:187–188, quiz slider `min: 40` app.js:211, `#wi-ret min="40"` index.html:86, FIRE hint EN/FR i18n.js:96/357. All acceptance checks re-executed fresh in this pass: + +| Check | Fresh output (this pass) | +|---|---| +| `tests/engine.test.js` | `RESULT: 61 pass, 0 fail` (incl. §14 GIS $0 @56 / clawback $0 @55 repro, §15 clawback 0 pre-OAS & capped at OAS gross @67, §16 couple invariants + depletion-never-fires-on-mixed, §17 fillDefaults 52→53 & 30→40, FIRE first draw 40, GIS/clawback 0 rows 40–64, stale 52/40 → first draw 53) | +| `tests/i18n.test.js` | `I18N-OK all i18n checks passed (50)` (incl. `t.mixedNote` EN+FR parity starting with `†`, `q.retire.hint` FIRE EN+FR) | +| `tests/ui.smoke.js` | `SMOKE-OK all ui smoke checks passed (146)` (incl. † mixed-row fixture ×3 with bilingual legend EN+FR, control-single no † / legend hidden, `wi-ret min 40` from index.html, legend element present) | +| `tests/ps-pension.test.js` / `ps-auto-service.test.js` | `70 pass, 0 fail` / `21 pass, 0 fail` (unchanged files) | +| `passes3.js` rerun (live engine) | exit 0, `conservation: OK` ×3 → `audit/math-fix/passes3-pass23.txt` (md5 `01075d0e…` — **byte-identical to passes 14–22**, ten consecutive deterministic passes). Line-tracked column scan (`scan3.py`, age/RRSP/TFSA/NonReg/Total/Withdraw/CPP/OASnet/GIS/Tax+clw/Unfunded/phase): PASS 1 (screenshot repro) 43 rows firstDraw 55 — **0** GIS>0 rows <65 (plan evidence $12,916 @56 / phantom $13,667/yr to 94 gone), **0** OASnet≠0 rows <65 (plan evidence −$3,501 @55 gone), **0** negative-OASnet, **0** growing-Total-with-Withdraw consecutive rows; row 55 Total $68,327 / Withdraw $102,139 / **OASnet $0 / GIS $0**; first GIS row **65** (CPP $7,200, OASnet $9,150, GIS $12,567), depletion 56 honest (nest egg $170,465 vs $93k spend, finalBal $0, max totalBal $166,308 @54); PASS 2: 50 rows firstDraw 65 firstGIS 65, all invariant sets empty, depletion 82, max total $468,146 @64; PASS 3 FIRE: 65 rows, first draw @**40** (Withdraw $62,837, CPP/OAS/GIS $0), max total $493,710 @39 = hand-math 350000×1.035¹⁰ ✓, GIS $13,667 first at **65**, **0** pre-65 GIS, **0** violations, depletion 48 → unfunded gap exposed to 94 | +| `scripts/deploy.sh` | `DEPLOY-OK` (fresh this pass) | +| Origin byte-check | 3-way sweep `.tmp/mathfix23/sweep23.sh` (pass-22-lineage script, tag retarget only; tracked/ignored lists regenerated via `git ls-files`, `diff` vs pass-22 lists: byte-identical, 21+13; ssh `-n`, single remote md5 pass): local `site/` == `git cat-file blob origin/main:` == webroot `/mnt/better/appdata/retireapp` — tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch** → `SWEEP-OK`; `HEAD` == `origin/main` == `9838113` | +| Live recapture (`mathfix_capture.py after23` + canonical `after`, retire.krisforbes.ca) | couple 52/52 ret 55 spend 93k CPP 60, K-aware 11-column parse (`.tmp/mathfix23/rowsweep.py`): **ROWSWEEP-OK** on all four row JSONs — 40 rows, first draw **55**, first GIS **65**, **0** neg-OAS, **0** GIS>0 <65, **0** OAS≠0 <65, **0** growing-Total-with-Withdraw; rows 58–64 Total $0 / OAS $0 / GIS $0 (Withdraw $49K @58 then $0, Unfunded $47K→$93K→$79K from CPP@60 — honest post-depletion drain, vs the screenshot's impossible 126→141K @3.5%); `wiRetMin: "40"`, `noteShown: false`. FIRE 30/BC/ret 40 (`after-fire-rows.json`, 57 rows): `fire_first_draw_age: "40"`, first GIS 65, **0** violations. Mobile 390: retire slider `min=40 max=72 value=40`, `sliderRight 367 ≤ vw 390` (no clip), chip [25, 145], FIRE hint EN present, `svAfter40: "40 years"` | +| Live mixed-window probe (`after23-mixed-*`, pass-14-lineage) | couple me 52 / pt 50, `retireAge: 51` → `fillDefaults` clamps self to 53, partner inherits the shared clamped 53 → both draw from 53: 43 rows, firstDraw **53** (K-aware re-parse; the probe's own `firstDrawAge: null` is its unpatched K-format limitation, identical in passes 14–22), firstGIS **65**, **0 † rows**, `noteShown: false`, K-aware re-parse: **0** GIS>0 <65, **0** OAS≠0 <65, **0** neg-OAS, **0** growWW → reconfirms Deviation 2 (age-axis merge + shared clamped `retireAge` ⇒ mixed draw windows unreachable in the live couple path); the `†` suffix + bilingual legend is proven by `ui.smoke.js` `project()` fixtures and engine §16 | +| Off-LAN (Midhurst `trouble@100.96.20.61`) | `OFFLAN-OK`, `"all_ok": true`, `"http_code": "200"`, `checked_at 2026-10-09T22:12:57Z` → `audit/bilingual-geo-check.json` | + +Determinism: `after23-couple-rows.json` md5 `129e2a45…` — **byte-identical** to the canonical `after-couple-rows.json` re-captured in the same session (same as passes 14–22); `after23-mixed-rows.json` md5 `96665bbf…` byte-identical to `after15–22-mixed-rows.json`; `after-fire-rows.json` ROWSWEEP-OK (57 rows, firstDraw 40, firstGIS 65). Frame-set observation (roles match pass 22, mirror of pass 21): the `after23` couple run **landed on the canonical frame on the first attempt** — 1280×900 50,314 B md5 `cbac51ed5089…`, byte-identical to the canonical renders of passes 1/8–19/21; the canonical `after` couple run landed on the known chart-animation-phase frame `eec99021c08c…` 63,753 B (pass-11/13–20/22 variant). Both IHDR-validated 1280×900; DOM row JSON byte-identical on both (`129e2a45…`), so the evidence row set is unchanged. `after23-mixed-table.png` md5 `222c81a1…` 64,537 B byte-identical to `after14/17/18/19/22-mixed-table.png`; `after-fire-table.png` `685fd711…` 67,310 B (passes-12–17/20–22 frame); `after-fire-step-390.png` 1170×2532 @3× `761e8055…` 167,045 B stable. All five fresh/updated PNGs IHDR-validated. `after23` tag captures only the couple scenario by script design (FIRE + mobile 390 under canonical `after`). + +Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner/.tmp/pw` (harness TMPDIR read-only; no site impact); ssh byte-check uses `-n`; this pass rebuilt sweep + K-aware rowsweep + mixed probe + row scan under `.tmp/mathfix23/` (gitignored) from the pass-22 originals with only tag retargeting (`after22→after23`, `mathfix22→mathfix23`) and the file lists regenerated from `git ls-files` (21 tracked + 13 ignored, `diff`-proven byte-identical); all ran unmodified otherwise. `audit/math-fix/` is gitignored by design — artifacts are local evidence, referenced by path. + +No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main` (ancestor of HEAD, confirmed via `git merge-base --is-ancestor`); all gates fresh this pass. Final: **MATH_FIX_DONE**. diff --git a/audit/bilingual-geo-check.json b/audit/bilingual-geo-check.json index 2887519..7e58a70 100644 --- a/audit/bilingual-geo-check.json +++ b/audit/bilingual-geo-check.json @@ -5,7 +5,7 @@ "has_i18n_script": true, "i18n_js_fr_strings": true, "i18n_js_size": 39689, - "checked_at": "2026-10-09T22:09:54Z", + "checked_at": "2026-10-09T22:12:57Z", "vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)", "all_ok": true } \ No newline at end of file