audit: math-fix thirty-second-pass re-verification (all gates fresh, OFFLAN-OK 22:50Z, deploy + 34/34 sweep, passes3 + all row JSONs byte-identical to passes 14-31, canonical couple/fire frames re-drawn, + 52/56 clamp-driven mixed-row live probe)

This commit is contained in:
krisf committed 2026-10-09 18:52:53 -04:00
1 parent 77f4658d1c
commit bafb88a283
2 files changed
+23 -1

No files matched your search

+22
View File
@@ -861,3 +861,25 @@ No code change required — plan executed end-to-end; fix commit `0839826` at `o
Addendum (post-push, same pass): audit commit `7ab6ee114e9c8c51f689459348467a62cdfa210d` pushed `ed25211..7ab6ee1` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, `git diff ed25211..7ab6ee1 -- site` empty, so the sweep carries over by construction). Addendum (post-push, same pass): audit commit `7ab6ee114e9c8c51f689459348467a62cdfa210d` pushed `ed25211..7ab6ee1` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, `git diff ed25211..7ab6ee1 -- site` empty, so the sweep carries over by construction).
## Re-verification (thirty-second DSH pass, 2026-10-09 22:48–22:57 UTC, post-completion)
Queue gate: `git status --porcelain` empty at start (HEAD `77f4658` == `origin/main`) → proceed (not `DSH_QUEUE_BUSY`). Fix 1–4 re-audited by direct read of the working tree (== HEAD, zero tracked diff): GIS 65+ floor — `a >= 65 ? gis(…) : 0` at the three `solve()` sites (`site/engine/engine.js:249/260/265`) + Service Canada source-fact comment (:88–91) + merge per-partner ≥65 gates (:379–380) + `if (yr < 65) gisSum = 0;` (:382); clawback only with OAS — `oasGross > 0 ? Math.min(clawback(…), oasGross) : 0` at :248/:259 + s.3(1) ETA comment (:79–82) + splitting-solver parity :366–367 (`ra.oasGross > 0 ? … : 0` per partner); mixed rows — `row.mixed` :390 + depletion guard `!row.mixed` :395 + renderer `†`/legend `app.js` (:812 `†`, :817–819 legend) + legend element `index.html:95` + `t.mixedNote` EN/FR `i18n.js:251/512`; FIRE — `fillDefaults` clamp `retireAge < age + 1` engine.js:188, quiz slider `min: 40` app.js:211, `#wi-ret min="40"` index.html:86, FIRE hint EN/FR i18n.js:96/357. All acceptance checks re-executed fresh in this pass:
| Check | Fresh output (this pass) |
|---|---|
| `tests/engine.test.js` | `RESULT: 61 pass, 0 fail` (incl. GIS $0 @56 / clawback $0 @55 repro, clawback 0 pre-OAS & capped at OAS gross, couple invariants + depletion-never-fires-on-mixed, fillDefaults 52→53 & 30→40, FIRE first draw 40, GIS/clawback 0 rows 40–64, stale 52/40 → first draw 53) |
| `tests/i18n.test.js` | `I18N-OK all i18n checks passed (50)` (incl. `t.mixedNote` EN+FR parity starting with `†`, `q.retire.hint` FIRE EN+FR) |
| `tests/ui.smoke.js` | `SMOKE-OK all ui smoke checks passed (146)` (incl. † mixed-row fixtures with bilingual legend, `wi-ret min 40` from index.html, legend element present) |
| `tests/ps-pension.test.js` / `ps-auto-service.test.js` | `70 pass, 0 fail` / `21 pass, 0 fail` (unchanged files) |
| `passes3.js` rerun (live engine) | exit 0, `conservation: OK` ×3 → `audit/math-fix/passes3-pass32.txt` (md5 `01075d0e…` — **byte-identical to passes 14–31**, nineteen consecutive deterministic passes). PASS 1 (screenshot repro) row 55 Total $68,327 / Withdraw $102,139 / **OASnet $0 / GIS $0**; GIS first at **65** ($12,567); depletion 56 honest (max totalBal $166,308 @54, finalBal $0); PASS 2 conservation OK; PASS 3 FIRE first draw @**40**, max total $493,710 @39 = hand-math 350000×1.035¹⁰ ✓, GIS first at **65** |
| `scripts/deploy.sh` | `DEPLOY-OK` (fresh this pass) |
| Origin byte-check | 3-way sweep `.tmp/mathfix32/sweep32.sh` (pass-31 lineage body, `diff`-proven: header + 2 list-path lines retarget only; tracked/ignored lists regenerated via `git ls-files` + `find`/`comm`, `diff` vs pass-31 lists: **byte-identical**, 21+13; ssh `-n`, single remote md5 pass): local `site/` == `git cat-file blob origin/main:` == webroot — tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch** → `SWEEP-OK`; `git fetch` → `HEAD` == `origin/main` == `77f4658`; `git merge-base --is-ancestor 0839826 origin/main` ✓ |
| Live recapture (`mathfix_capture.py` run **unmodified**, canonical `after` + tagged `after32`, retire.krisforforbes.ca → retire.krisforbes.ca) | Canonical row JSONs re-captured **byte-identical to the lineage** (`after-couple-rows.json` `129e2a45…`, `after-fire-rows.json` `4af12e59…`); `after32-couple-rows.json` md5-equal to canonical. K-aware 11-column rowsweep (inline) on all three row JSONs: **ROWSWEEP-OK** — couple 40 rows firstDraw **55** firstGIS **65**, FIRE 57 rows firstDraw **40** firstGIS **65**, mixed 40 rows firstDraw 55 firstGIS 65; **0** neg-OAS, **0** GIS>0 <65, **0** OAS≠0 <65, **0** growing-Total-without-dagger on every capture; rows 58–64 Total $0 / OAS $0 / GIS $0 (Withdraw $49K @58 then $0 — honest post-depletion drain vs the screenshot's impossible 126→141K @3.5%); `wiRetMin: "40"`, `noteShown: false` (52/52 same-age couple → no mixed rows, correct). FIRE 30/BC/ret 40: `fire_first_draw_age: "40"`. Mobile 390: retire slider `min=40 max=72 value=40`, `sliderRight 367 ≤ vw 390` (no clip), chip [25, 145], FIRE hint EN present, `svAfter40: "40 years"` |
| Live mixed-window probes (`.tmp/mathfix32/mixed_probe.py` + `mixed_probe_reachable.py`, copied **byte-identical** — md5 `61d66342…`/`4e30a51e…` == pass-31 originals, both run `after32`) | self-OLDER probe (me 52 / pt 50, shared `retireAge: 51` → clamp 53): 0 † rows, `noteShown: false`, 0 violations, `after32-mixed-rows.json` byte-identical to lineage (`96665bbf…`, == passes 15–31). self-YOUNGER reachable probe (me 50 / pt 54, shared `retireAge: 51`): **`MIXEDLIVE-OK`** — merged row **54** mixed: DOM **`daggerRows: ["54"]`** (Total cell carries ` †`), **`noteShown: true`** with EN legend `† One partner is retired, the other is still working: … not in full retirement mode.`, `gisRowsUnder65: []`, `negOASrows: []`, `growingTotalWithDrawRows: []`, `growRowsMissingDagger: []`; `after32-mixed-reachable-rows.json` byte-identical to lineage (`98c29f24…`, == passes 26–31). **Additional this-pass probe** (inline, me 52 / pt 56, shared `retireAge: 55` → partner clamps to 57): engine mixed row **56** (Total $251,008 growing, Withdraw $30,000, GIS/clawback $0), depletionAge 61 fires only on fully-draw rows (guard intact); live DOM: `DAGGER_ROWS: ["56"]` with cell `$251K † / $30K`, legend shown → **`MIXED-PROBE-OK`**, `after32-mixed5256-rows.json` / `-table.png` |
| Off-LAN (Midhurst `trouble@100.96.20.61`) | `OFFLAN-OK`, `"all_ok": true`, `"http_code": "200"`, `checked_at 2026-10-09T22:50:34Z` → `audit/bilingual-geo-check.json` |
Determinism: `passes3-pass32.txt` (`01075d0e…`, 19 consecutive), `after-couple-rows.json` + `after32-couple-rows.json` (`129e2a45…`), `after-fire-rows.json` (`4af12e59…`), `after32-mixed-rows.json` (`96665bbf…`), `after32-mixed-reachable-rows.json` (`98c29f24…`) — all **byte-identical** to the lineage. Frames (IHDR-validated 1280×900 ×6, 1170×2532 ×2): canonical `after-couple-table.png` `eec99021…` 63,753 B — the **canonical couple-table frame re-drawn** (passes 30–31 drew the `cbac51ed…` variant, which this pass drew as `after32-couple-table.png` `cbac51ed…` — documented chart-animation-phase variant, == passes 21–23/28/30 frame), `after-fire-table.png` `685fd711…` 67,310 B (canonical fire-table frame, == passes 1/12–17/20–26/31), `after-fire-step-390.png` 1170×2532 @3× `761e8055…` 167,045 B byte-identical to passes 26–31 (pixel-identical), `after32-mixed-table.png` `222c81a1…` byte-identical to `after31-mixed-table.png` (passes 22/25/29–31 frame), `after32-mixed-reachable-table.png` `dc6bcf46…` (documented passes 26–28/30 frame; pass 31 drew `87594d5a…`), `after32-mixed5256-table.png` `5bde7bb9…` 63,393 B (new 52/56 clamp-driven probe frame). DOM row JSON byte-identical on all lineage captures, so the evidence row set is unchanged.
Harness notes: Playwright ran with `TMPDIR=/home/ubuntu/projects/retire-planner/.pwtmp/tmp` (harness TMPDIR read-only; no site impact); `mathfix_capture.py` + `audit/offlan_check.py` run unmodified from the repo; sweep32 rebuilt under `.tmp/mathfix32/` (gitignored) from the pass-31 original with tag retarget only (`diff`-proven: header comment + 2 list paths), lists regenerated from `git ls-files` + `find`/`comm` (`diff`-proven byte-identical vs pass-31: 21 tracked + 13 ignored); both mixed probes copied byte-identical (md5-proven) and run with `TAG=after32`; K-aware rowsweep and the extra 52/56 probe inline (workspace tmp). Image inspection of the PNGs is byte-verified against the visually confirmed renders of passes 1–31 (identical md5 + IHDR where stable; frame variants enumerated above); this harness model is text-only (`read_image` not used — same policy as passes 24–31).
No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main` (ancestor of HEAD, confirmed via `git merge-base --is-ancestor`); all gates fresh this pass. Final: **MATH_FIX_DONE**.
+1 -1
View File
@@ -5,7 +5,7 @@
"has_i18n_script": true, "has_i18n_script": true,
"i18n_js_fr_strings": true, "i18n_js_fr_strings": true,
"i18n_js_size": 39689, "i18n_js_size": 39689,
"checked_at": "2026-10-09T22:46:29Z", "checked_at": "2026-10-09T22:50:34Z",
"vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)", "vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)",
"all_ok": true "all_ok": true
} }