audit: math-fix fifteenth-pass re-verification (all gates fresh, OFFLAN-OK 21:46Z, deploy + 34/34 byte sweep, canonical couple frame on first attempt)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
krisfandClaude committed 2026-10-09 17:46:49 -04:00
1 parent c87f876770
commit ce5b69df3e
2 files changed
+26 -1

No files matched your search

+25
View File
@@ -409,3 +409,28 @@ Harness notes: Playwright run with `TMPDIR=/home/ubuntu/projects/retire-planner/
No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main`; all gates fresh this pass. Final: **MATH_FIX_DONE**. No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main`; all gates fresh this pass. Final: **MATH_FIX_DONE**.
Addendum (post-push, same pass): audit commit `99afe5259eb6…` pushed `45c950a..99afe52` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, so the sweep carries over by construction). Addendum (post-push, same pass): audit commit `99afe5259eb6…` pushed `45c950a..99afe52` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, so the sweep carries over by construction).
---
## Re-verification (fifteenth DSH pass, 2026-10-09 21:44–21:47 UTC, post-completion)
Queue gate: `git status --porcelain` empty at start, HEAD `3f6a44d` == `origin/main`, no job in flight → proceed (not `DSH_QUEUE_BUSY`). Fix 1–4 re-audited by direct read of the working tree (== HEAD, zero tracked diff): GIS 65+ floor — `a >= 65 ? gis(…) : 0` at the three `solve()` sites (engine.js:249/260/265) + Service Canada source-fact comment (:88–91) + merge per-partner ≥65 gates (:379–380) + `if (yr < 65) gisSum = 0;` (:382); clawback only with OAS — `oasGross > 0 ? Math.min(clawback(…), oasGross) : 0` at :248/:259 + s.3(1) ETA comment :80–83 + splitting-solver parity :366–367; mixed rows — `row.mixed` :390 + depletion guard `!row.mixed` :395 + renderer `†`/legend app.js:807–819 + legend element index.html:95 + `t.mixedNote` EN/FR i18n.js:251/512; FIRE — `fillDefaults` clamp `retireAge < age+1` engine.js:188, quiz slider `min: 40` app.js:211, `#wi-ret min="40"` index.html:86, FIRE hint EN/FR i18n.js:96/357. All acceptance checks re-executed fresh in this pass:
| Check | Fresh output (this pass) |
|---|---|
| `tests/engine.test.js` | `RESULT: 61 pass, 0 fail` (§14 T1 repro: clawback $0 @55, GIS $0 @56, OAS gross 0 @56, net OAS ≥ 0 every row, no GIS<65 anywhere; §15: 100k RRSP draw @55 → cw 0, 67y 150k draw → cw $9,150 capped at OAS gross; §16: couple GIS/clawback zero <65, net OAS ≥ 0, no growing-Total-with-Withdraw draw rows, household GIS @70, age-offset window rows 50–54, depletion guard intact, depletion never fires on a mixed row; §17: fillDefaults 52→53 & 30→40, FIRE first draw 40, rows 40–64 GIS/clawback 0, stale 52/40 state first draw 53) |
| `tests/i18n.test.js` | `I18N-OK all i18n checks passed (50)` (incl. `t.mixedNote` EN+FR parity, `q.retire.hint` FIRE EN+FR) |
| `tests/ui.smoke.js` | `SMOKE-OK all ui smoke checks passed (146)` (incl. † mixed-row fixture ×3 + bilingual legend, control-single no †, `wi-ret min 40`, legend element present) |
| `tests/ps-pension.test.js` / `ps-auto-service.test.js` | `70 pass, 0 fail` / `21 pass, 0 fail` (unchanged files) |
| `passes3.js` rerun (live engine) | exit 0, `conservation: OK` ×3 → `audit/math-fix/passes3-pass15.log` (copied to `passes3-thispass.log`; md5 `01075d0e…` — **byte-identical to pass 14** ⇒ engine output deterministic across passes). PASS 1 (screenshot repro): rows 52–64 **OASnet $0 / GIS $0** (plan evidence −$3,501 @55 / $12,916 @56 / phantom $13,667/yr to 94 — all gone), first GIS row **65** (GIS $12,567, OASnet $9,150), depletion 56 honest (nest egg $170,465 vs $93k spend, finalBal $0); PASS 2 depletion 82, GIS 65+ only; PASS 3 FIRE: first draw @**40** (Withdraw $62,837, CPP/OAS/GIS $0), max total $493,710 @39 = hand-math 350000×1.035¹⁰ ✓, GIS $13,667 first at 65, depletion 48 → unfunded $60,000/yr to 94 (self-funded gap exposed, not hidden) |
| `scripts/deploy.sh` | `DEPLOY-OK` (fresh this pass) |
| Origin byte-check | 3-way sweep `.tmp/sweep15.sh` (ssh `-n`, one remote md5 pass): local `site/` == `git cat-file origin/main:` == webroot `/mnt/better/appdata/retireapp` — tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch** → `SWEEP-OK`; `HEAD` == `origin/main` == `3f6a44d` |
| Live recapture (`mathfix_capture.py after15` + canonical `after`, retire.krisforbes.ca) | couple 52/52 ret 55 spend 93k CPP 60, all 40 DOM rows 55–94 parsed with a K-aware 11-column parser (`age, RRSP, TFSA, NonReg, Total, Withdraw, CPP, OAS, GIS, Tax+claw, Unfunded`; `—`/`K` cells handled): **0** negative-OAS cells, **0** GIS>0 rows <65, **0** OAS≠0 rows <65, **0** growing-Total-with-Withdraw rows on consecutive ages; first draw **55** (Withdraw $93K, Total $248K), rows 58–64 Total $0 / OAS $0 / GIS $0 (Withdraw $49K @58 then $0, Unfunded $47K→$93K — honest post-depletion drain, vs the screenshot's impossible 126→141K @3.5%), first GIS row **65** (GIS $12K, OAS $18K, Tax+claw $339 > 0 with OAS payable ✓); `wiRetMin: "40"`. FIRE 30/BC/ret 40 (`after-fire-rows.json`, 57 rows 30–94): first Withdraw>0 row age **40**, first GIS row 65, **0** pre-65 GIS / neg-OAS / growing-consecutive violations. Mobile 390: retire slider `min=40 max=72 value=40`, `sliderRight 367 ≤ vw 390` (no clip), value chip [25, 145], FIRE hint present EN, `svAfter40: "40 years"` |
| Live mixed-window probe (`after15-mixed-*`, re-run of the pass-14 probe) | couple me 52 / pt 50, `retireAge: 51` → `fillDefaults` clamps self to 53; partner inherits the shared clamped 53 → both draw from 53 (DOM row 53 Withdraw $93K, Total $237K; rows 50–52 accum, row 50 Total $155K / Withdraw $0) → **0 † rows**, `noteShown: false`, **0** GIS>0 rows <65, **0** OAS≠0 rows <65, **0** negative-OAS cells — reconfirms Deviation 2 (age-axis merge + shared clamped `retireAge` ⇒ mixed draw windows are unreachable in the live couple path); the `†` suffix + bilingual legend rendering is proven by the `ui.smoke.js` `project()` fixture (3 flagged rows, EN+FR) and the engine §16 invariants |
| Off-LAN (Midhurst `trouble@100.96.20.61`) | `OFFLAN-OK`, `"all_ok": true`, `"http_code": "200"`, `checked_at 2026-10-09T21:46:19Z` → `audit/bilingual-geo-check.json` |
Determinism: canonical `after-couple-table.png` **landed on the canonical frame on the first attempt** — 1280×900 50,314 B md5 `cbac51ed5089…`, byte-identical to the canonical renders of passes 1/8/9/10/11/12/13/14; the `after15`-tagged couple run landed on the known chart-animation-phase frame `eec99021c08c…` 63,753 B (pass-11/13/14 variant) with DOM row JSON **byte-identical** to the canonical capture (`129e2a45…`), exactly the pass-14 frame-set behaviour. `after15-mixed-rows.json` byte-identical to `after14-mixed-rows.json` (md5 `96665bbf…`). Fresh PNGs IHDR-validated: `after15-couple-table.png` (1280×900 63,753 B) / `after15-mixed-table.png` (1280×900 44,945 B) / `after-couple-table.png` (1280×900 50,314 B) / `after-fire-table.png` (1280×900 67,310 B), `after-fire-step-390.png` 1170×2532 @3× 167,045 B.
Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner/.pwtmp` (harness TMPDIR read-only; no site impact); ssh byte-check uses `-n`; sweep + K-aware row-sweep scripts at `.tmp/sweep15.sh` / `.tmp/mathfix15/rowsweep.py` (gitignored; the row-sweep is now a standalone script after this pass found the probe's inline `money()` returning `None` on `$NNK` cells — the probe's own naive parser never flags a K-formatted cell, so its "0 violations" verdicts are conservative; the K-aware re-parse of every captured JSON above is the authoritative sweep). `audit/math-fix/` is gitignored by design — artifacts are local evidence, referenced by path.
No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main`; all gates fresh this pass. Final: **MATH_FIX_DONE**.
+1 -1
View File
@@ -5,7 +5,7 @@
"has_i18n_script": true, "has_i18n_script": true,
"i18n_js_fr_strings": true, "i18n_js_fr_strings": true,
"i18n_js_size": 39689, "i18n_js_size": 39689,
"checked_at": "2026-10-09T21:40:43Z", "checked_at": "2026-10-09T21:46:19Z",
"vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)", "vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)",
"all_ok": true "all_ok": true
} }