audit: math-fix twenty-seventh-pass re-verification (all gates fresh, OFFLAN-OK 22:28Z, deploy + 34/34 byte sweep, passes3 + all row JSONs byte-identical to passes 14-26, reachable-mixed dagger + legend re-confirmed live, FIRE 390 frame pixel-identical)

This commit is contained in:
krisf committed 2026-10-09 18:31:10 -04:00
1 parent 89292291d5
commit fa3d3dc6fe
2 files changed
+26 -1

No files matched your search

+25
View File
@@ -732,3 +732,28 @@ Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner
No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main` (ancestor of HEAD, confirmed via `git merge-base --is-ancestor`); all gates fresh this pass; Deviation-2 gap closed with live `†` evidence. Final: **MATH_FIX_DONE**.
Addendum (post-push, same pass): audit commit `b8eaf89a2e04db7fb4c5afd57c66cd0b55ac270e` pushed `107262e..b8eaf89` → `origin/main` (report + fresh off-LAN stamp; code untouched, the plan's mandated fix commit `08398267040a832bdec0910626423f0dbfeb0a7f` remains the code change under test, confirmed ancestor of `HEAD`). Post-push `git fetch` + full byte sweep re-run vs the new `origin/main`: origin blob == local == webroot md5, tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch**; `HEAD` == `origin/main` (this addendum commit adds only report text — zero site-file delta, so the sweep carries over by construction).
---
## Re-verification (twenty-seventh DSH pass, 2026-10-09 22:26–22:33 UTC, post-completion)
Queue gate: `git status --porcelain` empty at start (HEAD `76474b1` == `origin/main`, post-fetch) → proceed (not `DSH_QUEUE_BUSY`). Fix 1–4 re-audited by direct read of the working tree (== HEAD, zero tracked diff): GIS 65+ floor — `a >= 65 ? gis(…) : 0` at the three `solve()` sites (`site/engine/engine.js:249/260/265`) + Service Canada source-fact comment (:88–91) + merge per-partner ≥65 gates (:376/:379–380) + `if (yr < 65) gisSum = 0;` (:382); clawback only with OAS — `oasGross > 0 ? Math.min(clawback(…), oasGross) : 0` at :248/:259 + s.3(1) ETA comment :79–82 + splitting-solver parity :366–367; mixed rows — `row.mixed` :390 + depletion guard `!row.mixed` :395 + renderer `†`/legend `app.js:807–819` (:812 `†`, :818–819 legend) + legend element `index.html:95` + `t.mixedNote` EN/FR `i18n.js:251/512`; FIRE — `fillDefaults` clamp `retireAge < age + 1` engine.js:188, quiz slider `min: 40` app.js:211, `#wi-ret min="40"` index.html:86, FIRE hint EN/FR i18n.js:96/357. All acceptance checks re-executed fresh in this pass:
| Check | Fresh output (this pass) |
|---|---|
| `tests/engine.test.js` | `RESULT: 61 pass, 0 fail` (incl. §14 GIS $0 @56 / clawback $0 @55 repro, §15 clawback 0 pre-OAS & capped at OAS gross @67, §16 couple invariants + depletion-never-fires-on-mixed, §17 fillDefaults 52→53 & 30→40, FIRE first draw 40, GIS/clawback 0 rows 40–64, stale 52/40 → first draw 53) |
| `tests/i18n.test.js` | `I18N-OK all i18n checks passed (50)` (incl. `t.mixedNote` EN+FR parity starting with `†`, `q.retire.hint` FIRE EN+FR) |
| `tests/ui.smoke.js` | `SMOKE-OK all ui smoke checks passed (146)` (incl. † mixed-row fixture ×3 with bilingual legend EN+FR, control-single no † / legend hidden, `wi-ret min 40` from index.html, legend element present) |
| `tests/ps-pension.test.js` / `ps-auto-service.test.js` | `70 pass, 0 fail` / `21 pass, 0 fail` (unchanged files) |
| `passes3.js` rerun (live engine) | exit 0, `conservation: OK` ×3 → `audit/math-fix/passes3-pass27.txt` (md5 `01075d0e…` — **byte-identical to passes 14–26**, fourteen consecutive deterministic passes). Line-tracked column scan (`.tmp/mathfix25/scan3.py`): PASS 1 (screenshot repro) 43 rows firstDraw 55 — **0** GIS>0 rows <65, **0** OASnet≠0 rows <65, **0** negative-OASnet, **0** growing-Total-with-Withdraw; row 55 Total $68,327 / Withdraw $102,139 / **OASnet $0 / GIS $0**; first GIS row **65** (CPP $7,200, OASnet $9,150, GIS $12,567), depletion 56 honest (max totalBal $166,308 @54, finalBal $0); PASS 2: 50 rows firstDraw 65 firstGIS 65, depletion 82, max total $468,146 @64; PASS 3 FIRE: 65 rows, first draw @**40** (Withdraw $62,837, CPP/OAS/GIS $0), max total $493,710 @39 = hand-math 350000×1.035¹⁰ ✓, GIS $13,667 first at **65**, depletion 48 → unfunded gap exposed to 94 |
| `scripts/deploy.sh` | `DEPLOY-OK` (fresh this pass) |
| Origin byte-check | 3-way sweep `.tmp/mathfix27/sweep27.sh` (pass-26-lineage script, tag retarget only; tracked/ignored lists regenerated via `git ls-files` + `find`/`comm`, `diff` vs pass-26 lists: byte-identical, 21+13; ssh `-n`, single remote md5 pass): local `site/` == `git cat-file blob origin/main:` == webroot `/mnt/better/appdata/retireapp` — tracked **21/21 (3-way)** + gitignored `site/vision/*.jpeg` **13/13 (2-way)** = **34/34 match, 0 mismatch** → `SWEEP-OK`; `HEAD` == `origin/main` == `76474b1` |
| Live recapture (`mathfix_capture.py after27` + FIRE/mobile via prefix-tagged copy, retire.krisforbes.ca) | couple 52/52 ret 55 spend 93k CPP 60, K-aware 11-column parse (`.tmp/mathfix27/rowsweep27.py`): **ROWSWEEP-OK** on both row JSONs — 40 rows, first draw **55**, first GIS **65**, **0** neg-OAS, **0** GIS>0 <65, **0** OAS≠0 <65, **0** growing-Total-with-Withdraw; rows 58–64 Total $0 / OAS $0 / GIS $0 (Withdraw $49K @58 then $0, Unfunded $47K→$93K→$79K from CPP@60 — honest post-depletion drain, vs the screenshot's impossible 126→141K @3.5%); `wiRetMin: "40"`, `noteShown: false`. FIRE 30/BC/ret 40 (`after27-fire-rows.json`, 57 rows): `fire_first_draw_age: "40"`, first GIS 65, **0** violations. Mobile 390: retire slider `min=40 max=72 value=40`, `sliderRight 367 ≤ vw 390` (no clip), chip [25, 145], FIRE hint EN present, `svAfter40: "40 years"` |
| Live mixed-window probes (`.tmp/mathfix25/mixed_probe.py` + `.tmp/mathfix26/mixed_probe_reachable.py`, both `after27`) | self-OLDER probe (me 52 / pt 50, shared `retireAge: 51` → clamps both to 53, both draw from 53): 0 † rows, `noteShown: false`, 0 GIS>0 <65, 0 OAS≠0 <65, 0 neg-OAS, `after27-mixed-rows.json` byte-identical to lineage `96665bbf…` (passes 15–26). self-YOUNGER reachable probe (me 50 / pt 54, shared `retireAge: 51`; partner copy clamps to 55): **`MIXEDLIVE-OK`** — merged row **54** mixed: DOM **`daggerRows: ["54"]`** (Total cell carries ` †`), **`noteShown: true`** with EN legend `† One partner is retired, the other is still working: … not in full retirement mode.`, **0** GIS>0 <65, **0** neg-OAS, **0** growing-Total-with-Withdraw rows missing `†`; `after27-mixed-reachable-rows.json` byte-identical to pass-26 (`98c29f24…`) |
| Off-LAN (Midhurst `trouble@100.96.20.61`) | `OFFLAN-OK`, `"all_ok": true`, `"http_code": "200"`, `checked_at 2026-10-09T22:28:24Z` → `audit/bilingual-geo-check.json` |
Determinism: `passes3-pass27.txt` (`01075d0e…`, 14 consecutive), `after27-couple-rows.json` (`129e2a45…` == canonical `after-couple-rows.json`), `after27-fire-rows.json` (`4af12e59…` == canonical), `after27-mixed-rows.json` (`96665bbf…` == passes 15–26), `after27-mixed-reachable-rows.json` (`98c29f24…` == pass 26) — all **byte-identical** to the lineage. Frames: `after27-couple-table.png` `eec99021…` 63,753 B (known chart-animation-phase frame, byte-identical to pass-25/26), `after27-fire-step-390.png` 1170×2532 @3× `761e8055…` 167,045 B byte-identical to pass 26 (pixel-identical, PIL diff bbox `None`), `after27-mixed-reachable-table.png` `87594d5a…` 65,278 B byte-identical to pass 26; `after27-fire-table.png` `b4ed3a16…` 53,323 B (known fire-table animation frame, recorded in passes 18–25 determinism lines; canonical `685fd711…` 67,310 B is the pass-1/12–17/20–24/26 frame) and `after27-mixed-table.png` `c1d065cc…` 51,653 B (== `after16-mixed-table.png` frame variant) — both are documented chart-animation-phase variants; DOM row JSON byte-identical on both, so the evidence row set is unchanged. All five PNGs IHDR-validated (1280×900 ×4, 1170×2532 ×1).
Harness notes: Playwright runs with `TMPDIR=/home/ubuntu/projects/retire-planner/.tmp/pw` (harness TMPDIR read-only; no site impact); ssh byte-check uses `-n`; this pass rebuilt sweep + K-aware rowsweep under `.tmp/mathfix27/` (gitignored) from the pass-26 originals with tag retargeting only (`mathfix26→mathfix27`, `after26→after27`; `diff`-proven body byte-identical modulo the tag), lists regenerated from `git ls-files` + `find`/`comm` (21 tracked + 13 ignored, `diff`-proven byte-identical vs pass-26), FIRE/mobile legs via the prefix-tagged copy of `mathfix_capture.py` (`TAG.startswith('after')`), plus the pass-25 lineage `mixed_probe.py` and pass-26 `mixed_probe_reachable.py` run unmodified with `TAG=after27`. First capture attempt hit a transient Chromium `net::ERR_CERT_VERIFIER_CHANGED` (cert-verifier process restart; zero site impact — immediate retry captured all legs cleanly; consistent with the render-race/flake notes of passes 12–14). PNG pixel diagnostics via Pillow (numpy absent): the two variant frames differ from the canonical frames only below y=234 (chart/table region), no scroll offset (best dy −8, residual unchanged) — pure animation-phase delta, as recorded across the lineage. `audit/math-fix/` is gitignored by design — artifacts are local evidence, referenced by path. Image inspection of the PNGs is byte-verified against the visually confirmed renders of passes 1–26 (identical md5 + IHDR where stable; known frame variants enumerated above); this harness model is text-only (`read_image` rejected: model declares no image input — same policy as passes 24–26).
No code change required — plan executed end-to-end; fix commit `0839826` at `origin/main` (ancestor of HEAD, confirmed via `git merge-base --is-ancestor`); all gates fresh this pass. Final: **MATH_FIX_DONE**.
+1 -1
View File
@@ -5,7 +5,7 @@
"has_i18n_script": true,
"i18n_js_fr_strings": true,
"i18n_js_size": 39689,
"checked_at": "2026-10-09T22:23:02Z",
"checked_at": "2026-10-09T22:28:24Z",
"vantage": "trouble@100.96.20.61 (Midhurst, off-LAN)",
"all_ok": true
}